Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalization Check fails (makes it impossible to depend JavaProject on NativeProject) #90

Open
olpaw opened this issue Mar 17, 2016 · 1 comment
Assignees
Labels

Comments

@olpaw
Copy link
Member

olpaw commented Mar 17, 2016

The suite.py constellation below causes:

Traceback (most recent call last):
  File "/home/pwoegere/labs/xxx/mx_olpaw/mx_gate.py", line 267, in gate
    if mx.command_function('canonicalizeprojects')([]) != 0:
  File "/home/pwoegere/labs/xxx/mx_olpaw/mx.py", line 8931, in canonicalizeprojects
    if pkg in dep.extended_java_packages():
AttributeError: 'NativeProject' object has no attribute 'extended_java_packages'
gate: 17 Mar 2016 15:07:00: ABORT: Gate [0:00:11.244213] [disk (free/total): 305.7GB/430.1GB]
'NativeProject' object has no attribute 'extended_java_packages'

I think it should be possible for a JavaProject to depend on a NativeProject:

    "com.oracle.xxx.core.dis" : {
      "subDir" : "xxx",
      "sourceDirs" : ["src"],
      "dependencies" : [
        "com.oracle.xxx.core",
        "com.oracle.xxx.core.dis.native",
      ],
      "annotationProcessors" : [
        "graal-core:GRAAL_NODEINFO_PROCESSOR",
        "graal-core:GRAAL_REPLACEMENTS_VERIFIER",
        "graal-core:GRAAL_OPTIONS_PROCESSOR",
        "truffle:TRUFFLE_DSL_PROCESSOR",
      ],
      "javaCompliance" : "1.8",
      "checkstyle" : "com.oracle.xxx.truffle",
      "workingSets" : "XXX",
      "findbugs" : "false",
    },

    "com.oracle.xxx.core.dis.native" : {
      "native" : True,
      "subDir" : "xxx",
      "dependencies" : ["DISTORM"],
      "output" : "clibraries",
      "results" : [
        "libdistorm3.a",
        "include/distorm.h",
        "include/mnemonics.h",
      ]
    },

Here com.oracle.xxx.core.dis depends on com.oracle.xxx.core.dis.native. Unfortunately using the definition above results in the error shown before.

@olpaw olpaw added the bug label Mar 17, 2016
dougxc added a commit that referenced this issue May 23, 2016
* commit '0273dda510caabbe6dc55a2fc2d86401d463814e':
  bootclasspath is empty string on jdk >= 9 handle new 2 arg JVM options when partitioning command line args
@dougxc
Copy link
Member

dougxc commented Jan 17, 2018

Can we close this issue @olpaw ?

@dougxc dougxc self-assigned this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants