-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sforceimports does not fetch from the repository specified in the suite #78
Comments
/cc @gilles-duboscq |
I'd say it should check that the repo has a remote which is the same as the one specified in the suite and complain. It could maybe offer to add the remote or tell you how to do it. We also seem to be assuming that after a fetch the changeset we are looking for will be there. Maybe we should rerun the exists query after the fetch to ensure we really got the result we expected. |
@zapster, I think it would be best if someone who uses |
Well I do think that GitConfig.pull should complain if the pull doesn't produce the rev being requested. hg doesn't have this problem but git simply ignores the rev because you can't really pull a particular rev with git. That's the source of the fatal messages because we later assume the rev is there but it's not. If you don't use sforceimport what do you use? Manually getting revs from the suite.py? |
Yes. |
#81 is already a great improvement, thanks @tkrodriguez. I'd still like a flag that uses the specified upstream repo (maybe |
* commit '5f47c88ee79ab39f4645e6ce717a0c81e22377f5': Re-add quiet flag to hg_command and git_command.
mx sforceimport
does not use the location specified in the suites to fetch new revisions but the default remote of the clone. This is for example a problem if one uses a fork as default but the fork does not contain the revision that is requested.results in:
I think we should per default fetch from the repository specified in the suite and add a flag to disable the behavior for scenarios where we never want to use local mirrors.
The text was updated successfully, but these errors were encountered: