Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update checkstyle version to 6.15 #25

Closed
mrigger opened this issue Feb 2, 2016 · 0 comments
Closed

update checkstyle version to 6.15 #25

mrigger opened this issue Feb 2, 2016 · 0 comments

Comments

@mrigger
Copy link
Contributor

mrigger commented Feb 2, 2016

When using newer versions of Checkstyle the RedundantModifier module is able to find more code style violations. We need to upgrade the version but have to take care about the following things:

  • The JVMCI, Graal, and Truffle violations need to be fixed. I already fixed the violations in JVMCI and Graal. Probably, we have to fix new violations shortly before using the new Checkstyle version.
  • Projects that have dependencies on older versions of mx still need to use the current Checkstyle version. I opened a branch with a naive update, that does not yet support the older Checkstyle version: https://github.com/graalvm/mx/tree/update-checkstyle
This was referenced Feb 2, 2016
Merged
Closed
Merged
@zapster zapster closed this as completed Feb 11, 2016
dougxc pushed a commit that referenced this issue Apr 13, 2016
@axel22
Merge pull request #25 in G/mx from ~ALEKSANDAR.PROKOPEC_ORACLE.COM/m…
fe9fb14 
…x:topic/show-version-string to master

* commit '8c96123b4de71f440c0b42b5f798513a3f0803c9':
  Add before hook, and show version string when running JVM benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zapster @mrigger