Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tmux fails to start #593

Closed
luisdavim opened this issue Aug 19, 2022 · 5 comments
Closed

Tmux fails to start #593

luisdavim opened this issue Aug 19, 2022 · 5 comments
Labels
bug

Comments

@luisdavim
Copy link
Contributor

luisdavim commented Aug 19, 2022 •
edited
Loading

Hi, I've updated to the latest version and since then tmux fails to start, I was able to trace the issue to 68a909d

If I checkout the commit before that one everything works again.

I'm running on Android in termux, I can try running on macOS tomorrow and see if the issue is specific to termux...

Let me know if there's any specific info you need.

update: If I checkout b620a4f it also works so it's probably an issue with the latest commit: 5fa30de and 68a909d is probably also broken but that issue was fixed in the following commit.
@luisdavim
Copy link
Contributor Author

luisdavim commented Aug 19, 2022 •
edited
Loading

I guess this has to do with the version of sh used in termux:

$ sh -c 'echo ${EDITOR//gvim/vim}'
sh: 1: Bad substitution

Setting line 29 to:

bind e new-window -n "~/.tmux.conf.local" sh -c '${EDITOR:-vim} ~/.tmux.conf.local && tmux source ~/.tmux.conf && tmux display "~/.tmux.conf sourced"'

Solves the problem....

Are those replacements really necessary? Why do we need to avoid using mvim and gvim?

luisdavim added a commit to luisdavim/.tmux that referenced this issue Aug 19, 2022
@luisdavim
fix: remove mvim and gvim substitutions
ca70c0b 
Fixes gpakosz#593
@luisdavim luisdavim mentioned this issue Aug 19, 2022
Closed
@luisdavim
Copy link
Contributor Author

#594 would solve this issue.

@gpakosz
Copy link
Owner

gpakosz commented Aug 20, 2022

Hello @luisdavim 👋

The substitutions have been introduced to fix #416.

@gpakosz gpakosz added the bug label Aug 20, 2022
@gpakosz
Copy link
Owner

gpakosz commented Aug 20, 2022

Maybe I could do some introspection and check if EDITOR is set to gvim or mvim and launch them with -f. But let's remove the substitutions for now.

@luisdavim
Copy link
Contributor Author

Maybe I could do some introspection and check if EDITOR is set to gvim or mvim and launch them with -f. But let's remove the substitutions for now.

yeah, but if we go down that path there would be many more editors to take care of like VSCode, IntelliJ, some flavours of emacs, etc....

@gpakosz gpakosz mentioned this issue Aug 22, 2022
Closed
thisisrandy pushed a commit to thisisrandy/.tmux that referenced this issue Sep 8, 2022
@luisdavim @thisisrandy
fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' a…
00e5904 
…nd the default shell is zsh (2), fixes gpakosz#593

${EDITOR//gvim/vim} and ${EDITOR//mvim/vim} have been introduced to fix gpakosz#416,
however the replace all substitution is not POSIX and is not supported by termux
or dash

the proper fix for gpakosz#416 is to set EDITOR to 'gvim -f' or 'mvim -f'
R-Broadley pushed a commit to rob-broadley/.tmux that referenced this issue Nov 20, 2022
@rob-broadley
Merge remote-tracking branch 'upstream/master'
e8982c6 
* upstream/master:
  fixed custom variables detection, fixes gpakosz#613
  bind p to paste-buffer -p to match tmux defaults, closes gpakosz#610
  added support for wl-clipboard, closes gpakosz#589, closes gpakosz#606
  fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' and the default shell is zsh (2), fixes gpakosz#593
  fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' and the default shell is zsh, fixes gpakosz#591
  turn off history substitution in case it's been enabled (2), fixes gpakosz#583
  turn off history substitution in case it's been enabled, closes gpakosz#582
  added a way to mark set/bind/unbind commands as important in ~/.tmux.conf.local, closes gpakosz#571
  updated the weather() sample function, closes gpakosz#580
  added a way to selectively disable binding manipulation, closes gpakosz#514
  reworked pane / tty introspection (5), fixes gpakosz#573
  added RGB 24-bit colour support automatic detection
  pass #{pane_current_path} to _fpp() and then to split-window
ooosssososos pushed a commit to ooosssososos/.tmux that referenced this issue Mar 1, 2023
@luisdavim @ooosssososos
fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' a…
b75b971 
…nd the default shell is zsh (2), fixes gpakosz#593

${EDITOR//gvim/vim} and ${EDITOR//mvim/vim} have been introduced to fix gpakosz#416,
however the replace all substitution is not POSIX and is not supported by termux
or dash

the proper fix for gpakosz#416 is to set EDITOR to 'gvim -f' or 'mvim -f'
farhadkarimi pushed a commit to farhadkarimi/.tmux that referenced this issue Aug 18, 2023
@luisdavim
fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' a…
4628291 
…nd the default shell is zsh (2), fixes gpakosz#593

${EDITOR//gvim/vim} and ${EDITOR//mvim/vim} have been introduced to fix gpakosz#416,
however the replace all substitution is not POSIX and is not supported by termux
or dash

the proper fix for gpakosz#416 is to set EDITOR to 'gvim -f' or 'mvim -f'
Rafiot pushed a commit to Rafiot/.tmux that referenced this issue Jan 24, 2024
@luisdavim @Rafiot
fixed <prefix>+e not working when EDITOR is set to 'emacsclient -t' a…
ee3dd05 
…nd the default shell is zsh (2), fixes gpakosz#593

${EDITOR//gvim/vim} and ${EDITOR//mvim/vim} have been introduced to fix gpakosz#416,
however the replace all substitution is not POSIX and is not supported by termux
or dash

the proper fix for gpakosz#416 is to set EDITOR to 'gvim -f' or 'mvim -f'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove mvim and gvim substitutions luisdavim/.tmux
2 participants
@luisdavim @gpakosz