Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force I-frame on SCTE-35 breaks #2879

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Conversation

DenizUgur
Copy link
Contributor

@DenizUgur DenizUgur commented Jun 15, 2024

Added a new option for scte35dec that would copy the incoming packets to its output. During this operation, if a SCTE-35 splice point is encountered, that packet is marked to be encoded as an I-frame.

I wanted to use GF_PROP_PCK_CUE_START but that forces the encoder to reconfigure and during my tests libx264 entered into a reconfiguration loop.

  • Test with more content
  • Decide on the option name
  • Find out how to work with GF_PROP_PCK_CUE_START
  • Not all events trigger IDR, need to handle that scenario
  • unit tests
  • test suite

@DenizUgur DenizUgur marked this pull request as ready for review June 15, 2024 01:30
@DenizUgur DenizUgur marked this pull request as draft June 15, 2024 01:33
src/filters/dec_scte35.c Outdated Show resolved Hide resolved
src/filters/dec_scte35.c Outdated Show resolved Hide resolved
@DenizUgur
Copy link
Contributor Author

@jeanlf any idea why GF_PROP_PCK_CUE_START puts ff_enc into reconfiguration loop? From what I can tell, the encoder is trying to consume the same packet repeatedly and that causes this loop. There might be other stuff as well.

@DenizUgur
Copy link
Contributor Author

Last commit fixed the encoder reconfiguration issue. It can be cherry-picked from this PR if it's satisfactory.

@rbouqueau rbouqueau requested a review from jeanlf June 19, 2024 15:48
src/filters/ff_enc.c Outdated Show resolved Hide resolved
@DenizUgur DenizUgur marked this pull request as ready for review June 20, 2024 17:34
Copy link
Member

@rbouqueau rbouqueau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbouqueau rbouqueau merged commit a340838 into gpac:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants