Support packaging of generic ID3 tags into ISOBMFF coming from TS streams. #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ID3 demuxing and packaging implementation only supports Nielsen-specific tags with a fixed data size and scheme URI.
This URI improves upon those changes by supporting generic tags of any size. The TS demuxer detects whether the incoming ID3 tag corresponds to a Nielsen ID3 tag, and sets its corresponding scheme URI for later use. Otherwise, it uses
https://aomedia.org/emsg/ID3for both scheme and value URI.