Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parents of moov,cmov,cmvd in box_funcs #2857

Closed
wants to merge 1 commit into from

Conversation

y-guyon
Copy link
Contributor

@y-guyon y-guyon commented Jun 3, 2024

See context at
AOMediaCodec/libavif#2182

@y-guyon
Copy link
Contributor Author

y-guyon commented Jun 3, 2024

This requires many further changes to compile.
Abandoning, even though displaying <MovieBox Container="file cmvd"> is misleading for an AVIF file.

@y-guyon y-guyon closed this Jun 3, 2024
@y-guyon
Copy link
Contributor Author

y-guyon commented Jun 3, 2024

Adapting gf_isom_box_dump_start_ex() to print the actual box parent instead of the possible containers would be another way to go:

gf_fprintf(trace, "Container=\"%s\" ", a->registry->parents_4cc);

but gf_isom_box_dump_start() does not provide this context and is called too many times.

jeanlf added a commit that referenced this pull request Jun 4, 2024
@jeanlf
Copy link
Member

jeanlf commented Jun 4, 2024

I patched the container code for cmov/cmvd which were indeed wrong. Note that MP4Box -diso will not show cmof/cmvd as these are lost when we load the file; they can only be seen when activating logs for container@debug.

@y-guyon y-guyon deleted the patch-1 branch June 4, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants