Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇨🇭 Add Switzerland #398

Merged
merged 9 commits into from
Jun 22, 2024
Merged

🇨🇭 Add Switzerland #398

merged 9 commits into from
Jun 22, 2024

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Jun 7, 2024

I removed the Qids from the "unconfirmed" authorities/agencies (no official source) and I added the Swiss municipalities as well.

Fixes: #222

I removed the Qids from the "unconfirmed"  authorities/agencies (no official source) and I added the Swiss municipalities as well.
@Ainali
Copy link
Member

Ainali commented Jun 21, 2024

Thanks for picking this up! The query works well, and this is a considerable addition, very cool!
You just forgot to add Switzerland to views.yaml.

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Jun 21, 2024

Ignore adding and then removing... Busy day today.

queries/countries.rq Outdated Show resolved Hide resolved
Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent addition, thanks for getting this ready!

This PR will also supersede #222 that can be closed after this has been merged.

@Ainali Ainali merged commit ebcbc07 into govdirectory:main Jun 22, 2024
1 check passed
@RVA2869 RVA2869 deleted the Add-Switzerland branch June 22, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants