Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧼🧽 Clean up CSS #386

Merged
merged 4 commits into from
May 25, 2024
Merged

🧼🧽 Clean up CSS #386

merged 4 commits into from
May 25, 2024

Conversation

RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented May 22, 2024

  • unnecessary code removed (details)
  • standardize colors (all in lowercase hex)
  • set a fixed width and height of the round buttons. (no CSS)
  • timestamp section has been fixed

    before:
.timestamp {
    text-align: right;
    margin-top: 0.5;
    margin-bottom: 0;

after:

.timestamp {
   text-align: right;
   margin-top: .5em;
   margin-bottom: 0;
 }

The unit was missing from margin-top.

@Ainali
Copy link
Member

Ainali commented May 24, 2024

Thanks for starting on this maintenance task!

I like the unifying of cases and great with the explicit height and width of the buttons.

I am not sure about removing units when the value is zero, nor removing the zero when the value is between 0 and 1. Both those reduce legibility in my opinion.

I don't understand what you mean with "unnecessary code removed (details)", could you explain that further?

@Abbe98
Copy link
Member

Abbe98 commented May 24, 2024

I like it and I think it makes it more consistent.

static/main.css Outdated
@@ -261,7 +261,7 @@ footer li {
}

.white-bg {
background-color:#FFF;
background-color:#fff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a space here as we are doing a cleanup.

@Abbe98
Copy link
Member

Abbe98 commented May 24, 2024

Super minor note from my end, but that's it.

add space
@RVA2869
Copy link
Collaborator Author

RVA2869 commented May 25, 2024

I don't understand what you mean with "unnecessary code removed (details)", could you explain that further?

The unnecessary code is this:

I am not sure about removing units when the value is zero, nor removing the zero when the value is between 0 and 1.

Even with my limited knowledge of CSS, I can still read it.
The main user of the CSS is of course the browser (humans are a bonus)😉.

@Ainali Ainali merged commit c779594 into govdirectory:main May 25, 2024
1 check passed
@RVA2869 RVA2869 deleted the fix-css branch May 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants