Add upstart check for /etc/init/<service>.override #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, can you modify the dockerfile/tests to validate this? |
aelsabbahy
requested changes
Jun 12, 2017
integration-tests/test.sh
Outdated
| @@ -39,6 +39,9 @@ trap "rv=\$?; docker rm -vf $id; exit \$rv" INT TERM EXIT | |||
| # Give httpd time to start up, adding 1 second to see if it helps with intermittent CI failures | |||
| [[ $os != "arch" ]] && docker_exec "/goss/$os/goss-linux-$arch" -g "/goss/goss-wait.yaml" validate -r 10s -s 100ms && sleep 1 | |||
|
|
|||
| # Disable apache2 service on boot for "precise" | |||
There was a problem hiding this comment.
Can this be moved to the docker file.
Aside from that, this PR looks great!
|
Thanks, will review, merge and release later in the week. Looks good. |
aelsabbahy
approved these changes
Jul 1, 2017
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Add upstart check for /etc/init/<service>.override containing "manual" keyword * Add tests for upstart <service>.override * Move apache2.override to precise Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks wether the service is disabled with the upstart override file
/etc/init/<service>.override.Before this, even if you had manually overridden the service to be
manualit would just check the upstart file/etc/init/<service>.confand report the service as enabled when it wasn't.