Escape special characters in JUnit XML output #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, characters such as '>' in tests were not escaped in the generated JUnit XML output (resulting in malformed output). Now, such characters are escaped. References goss-org#203
|
Apologies, I completely forgot about this PR. I'll merge it in as part of the next release. |
Colour output is currently interfering with the XML escaping, so we remove it. References goss-org#203
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Escape special characters in JUnit XML output Previously, characters such as '>' in tests were not escaped in the generated JUnit XML output (resulting in malformed output). Now, such characters are escaped. References goss-org#203 * Disable colour in JUnit output Colour output is currently interfering with the XML escaping, so we remove it. References goss-org#203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, characters such as
>in tests were not escaped in thegenerated JUnit XML output (resulting in malformed output).
Now, such characters are escaped.
This is my first experience with Go, so I'm definitely keen to improve
this.
References #203