-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 200, HEAD and OPTIONS with constants from net/http #243
Conversation
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 7 7
Lines 598 598
=======================================
Hits 505 505
Misses 82 82
Partials 11 11
|
@iBug Would you mind posting the results of the |
@coreydaley Ubuntu 22.04 LTS, Go 1.20.7. With one exception (first one below), all errors are from files under
However, if I do |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/gorilla/handlers](https://togithub.com/gorilla/handlers) | `v1.5.1` -> `v1.5.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgorilla%2fhandlers/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgorilla%2fhandlers/v1.5.1/v1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gorilla/handlers (github.com/gorilla/handlers)</summary> ### [`v1.5.2`](https://togithub.com/gorilla/handlers/releases/tag/v1.5.2) [Compare Source](https://togithub.com/gorilla/handlers/compare/v1.5.1...v1.5.2) #### What's Changed - build: CircleCI 2.1 + build matrix by [@​elithrar](https://togithub.com/elithrar) in [https://github.com/gorilla/handlers/pull/199](https://togithub.com/gorilla/handlers/pull/199) - Update README.md by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239) - added makefile, github-actions and updated go version by [@​bharat-rajani](https://togithub.com/bharat-rajani) in [https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241) - Update issues.yml by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/handlers/pull/242](https://togithub.com/gorilla/handlers/pull/242) - Replace 200, HEAD and OPTIONS with constants from net/http by [@​iBug](https://togithub.com/iBug) in [https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243) - update GitHub workflows by [@​coreydaley](https://togithub.com/coreydaley) in [https://github.com/gorilla/handlers/pull/251](https://togithub.com/gorilla/handlers/pull/251) #### New Contributors - [@​coreydaley](https://togithub.com/coreydaley) made their first contribution in [https://github.com/gorilla/handlers/pull/239](https://togithub.com/gorilla/handlers/pull/239) - [@​bharat-rajani](https://togithub.com/bharat-rajani) made their first contribution in [https://github.com/gorilla/handlers/pull/241](https://togithub.com/gorilla/handlers/pull/241) - [@​iBug](https://togithub.com/iBug) made their first contribution in [https://github.com/gorilla/handlers/pull/243](https://togithub.com/gorilla/handlers/pull/243) **Full Changelog**: gorilla/handlers@v1.5.1...v1.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaegertracing/jaeger). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
What type of PR is this? (check all applicable)
Description
A previous commit (#241) replaced most HTTP constants with those from standard library
net/http
, but some was missed. This PR catches 3 of them.Related Tickets & Documents
Added/updated tests?
Run verifications and test
make verify
is passing (which I believe is not my fault)make test
is passing