feat(c/libuv): Add libuv missing funcs & refactor go func style #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolve conflict please |
f04aaef
to
50860d9
Compare
|
ci is not passed. |
Signed-off-by: hackerchai <[email protected]> feat(c/libuv): Add uv_signal_stop func Signed-off-by: hackerchai <[email protected]> feat(c/libuv): Add GetIoWatcher, GetFd func & add Io srtuct Signed-off-by: hackerchai <[email protected]> refactor(c/libuv): Rename some func refactor(c/libuv): Remove net go wrapper refactor(c/libuv): Add GetIoWatcherFd func
refactro(c/libuv): Use cgo alias avoid implicit struct member declaration
This reverts commit 1ce1672. Signed-off-by: hackerchai <[email protected]>
This reverts commit 45ba5b8. # Conflicts: # c/libuv/net.go
50860d9
to
8848222
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 19 19
Lines 4584 4584
=======================================
Hits 4473 4473
Misses 94 94
Partials 17 17 ☔ View full report in Codecov by Sentry. |
ci passed. ready for review. @xushiwei |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hackerchai [email protected]