Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss.com.hk, GitHub, HKGolden, ProjectV, TopickHK & WikiLeaks #310

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Discuss.com.hk, GitHub, HKGolden, ProjectV, TopickHK & WikiLeaks #310

merged 3 commits into from
Feb 10, 2019

Conversation

functionxxx
Copy link

fix ip

@welcome
Copy link

welcome bot commented Feb 9, 2019

Thanks for your contribution!
SAFETY NOTE: Please consider submit your changes as beyondgfw <[email protected]>. We strongly recommend you to do so for your anonymity.
Also, if you are contributing to the HOSTS file:

  • Make sure your pull request's base branch is hosts-source.
  • Per 维护方案 #48 please make sure you are not using one single IP for multiple domains whenever possible.
    Other requirements are listed on the CONTRIBUTING page.

@beyondgfw
Copy link
Member

@functionxxx 150.95.236.68 is available, no need to replace

@functionxxx
Copy link
Author

@functionxxx 150.95.236.68 is available, no need to replace

Yep, but the original ip 157.7.225.122 is not available.

@beyondgfw
Copy link
Member

@functionxxx Sorry,
157.7.225.122 is available, no need to replace x

@beyondgfw
Copy link
Member

@functionxxx len=44 ip=157.7.225.122 ttl=109 DF id=14817 sport=443 flags=SA seq=0 win=8192 rtt=91.7 ms
len=44 ip=157.7.225.122 ttl=109 DF id=14818 sport=443 flags=SA seq=1 win=8192 rtt=103.6 ms

@functionxxx
Copy link
Author

@beyondgfw Okay. Shall I modify my pull request?

@sxyoxygen
Copy link
Contributor

@functionxxx Of course you can, go ahead

@beyondgfw
Copy link
Member

Thanks for contributing

@beyondgfw beyondgfw merged commit 6116fc1 into googlehosts:hosts-source Feb 10, 2019
beyondgfw added a commit that referenced this pull request Feb 10, 2019
@beyondgfw
6116fc1 Hosts source (#310)
18a8a33 
* fix ip

* fix ip

* Add ip
@GoogleHostsSupport GoogleHostsSupport changed the title Hosts source Discuss.com.hk, GitHub, HKGolden, ProjectV, TopickHK & WikiLeaks Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Domain Missing IP Failure
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@functionxxx @beyondgfw @sxyoxygen @GoogleHostsSupport