fix: Add AWS session token to metadata requests #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47ae098
to
f2ddbea
Compare
arithmetic1728
approved these changes
Feb 4, 2022
Comment on lines
+566
to
+568
| headers = None | ||
| if session_token is not None: | ||
| headers = {"X-aws-ec2-metadata-token": session_token} |
There was a problem hiding this comment.
this can be done in one line:
Suggested change
| headers = None | |
| if session_token is not None: | |
| headers = {"X-aws-ec2-metadata-token": session_token} | |
| headers = {"X-aws-ec2-metadata-token": session_token} if session_token else None |
Comment on lines
+707
to
+709
| headers = None | ||
| if session_token is not None: | ||
| headers = {"X-aws-ec2-metadata-token": session_token} |
There was a problem hiding this comment.
Suggested change
| headers = None | |
| if session_token is not None: | |
| headers = {"X-aws-ec2-metadata-token": session_token} | |
| headers = {"X-aws-ec2-metadata-token": session_token} if session_token else None |
|
Hey Sai, can you please update the README too? I think it'll be important to document this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS instance metadata service v2 introduced a need for session token when making call to the meta data endpoints. This change add the code to fetch the session token and add to our requests to metadata urls.