Add Credentials implementation supplying an ID token. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed a significant portion of this so some else needs to review. @dhermes? |
dhermes
reviewed
Jan 19, 2018
google/oauth2/_client.py
Outdated
| @@ -155,6 +156,49 @@ def jwt_grant(request, token_uri, assertion): | |||
| return access_token, expiry, response_data | |||
|
|
|||
|
|
|||
| def id_token_jwt_grant(request, token_uri, assertion): | |||
| """Implements the JWT Profile for OAuth 2.0 Authorization Grants, but | |||
| requests an OpenID Connect ID Token instead of a access token. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/_client.py
Outdated
| Args: | ||
| request (google.auth.transport.Request): A callable used to make | ||
| HTTP requests. | ||
| token_uri (str): The OAuth 2.0 authorizations server's token endpoint |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/_client.py
Outdated
| URI. | ||
| assertion (str): JWT token signed by a service account. The assertion | ||
| must include a ``target_audience`` claim. | ||
| Returns: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/_client.py
Outdated
| token_uri (str): The OAuth 2.0 authorizations server's token endpoint | ||
| URI. | ||
| assertion (str): JWT token signed by a service account. The assertion | ||
| must include a ``target_audience`` claim. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/_client.py
Outdated
| Tuple[str, Optional[datetime], Mapping[str, str]]: | ||
| The (encoded) Open ID Connect ID Token, expiration, and additional | ||
| data returned by the endpoint. | ||
| Raises: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| self._token_uri = token_uri | ||
| self._target_audience = target_audience | ||
|
|
||
| if additional_claims is not None: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| delegated_credentials = credentials.with_subject(subject) | ||
|
|
||
| """ | ||
| def __init__(self, signer, service_account_email, token_uri, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/service_account.py
Outdated
| google.auth.service_account.IDTokenCredentials: A new credentials | ||
| instance. | ||
| """ | ||
| return IDTokenCredentials( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonparrott Here's a primitive implementation for #130.
This adds everything in
google.auth.id_tokenas I don't know any better.Could you advise on how to structure this better?
Thanks!