Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: check if response was successful in IDTokenCredentials.refresh #1251

Closed
wants to merge 3 commits into from
Closed

Fix: check if response was successful in IDTokenCredentials.refresh #1251

wants to merge 3 commits into from

Conversation

charlielito
Copy link

Fixes #1249

@charlielito charlielito requested review from a team as code owners March 14, 2023 21:01
arithmetic1728
arithmetic1728 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for your change. This repo requires 100% code coverage for any PR. You can run nox -s cover to check the coverage.

google/auth/impersonated_credentials.py
authed_session.close()

if response.status_code != http_client.OK:
raise exceptions.TransportError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceptions.RefreshError

@BigTailWolf BigTailWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2023
@BigTailWolf
Copy link
Contributor

CI tests failed due to not 100% coverage

google/auth/identity_pool.py                         66      0     24      0   100%
google/auth/impersonated_credentials.py             113      1     12      1    98%   439
google/auth/jwt.py                                  218      0     50      0   100%
google/auth/pluggable.py                            140      0     64      0   100%
google/auth/transport/__init__.py                    17      0      4      0   100%

@arithmetic1728
Copy link
Contributor

opened PR in #1315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError when generating IDTokenCredentials with bad permissions
4 participants
@charlielito @BigTailWolf @arithmetic1728 @yoshi-kokoro