Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Update token refresh threshold from 20 seconds to 5 minutes (#1146)" #1153

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Revert "fix: Update token refresh threshold from 20 seconds to 5 minutes (#1146)" #1153

merged 1 commit into from
Sep 26, 2022

Conversation

clundin25
Copy link
Contributor

This reverts commit 261a561.

@TimurSadykov
Copy link
Member

Why we do this? Did we get the confirmation that 5 min does not work?

@clundin25
Copy link
Contributor Author

clundin25 commented Sep 26, 2022 •
edited
Loading

Why we do this? Did we get the confirmation that 5 min does not work?

I want to cut a release to unblock other work. We don't want to commit to releasing this code yet

@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 26, 2022
@clundin25 clundin25 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 26, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 26, 2022
@clundin25 clundin25 merged commit 186464b into googleapis:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clundin25 @TimurSadykov @sai-sunder-s @yoshi-kokoro