-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE Credentials should not derive from Scoped #194
Comments
This was referenced Sep 11, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because
with_scopes
raisesNotImplementedError
, the class cannot be used polymorphically where instances ofScoped
are expected (see googleapis/google-cloud-python#3933). For instance, in C++,google.auth.compute_engine.credentials.Credentials
wouldn't even be instantiable, becausewith_scopes
is a pure virtual method cognate.If there is a need for part of the interface to be expressed (e.g., the
scopes
,requires_scopes
, andhas_scopes
methods), that should be factored into another class (maybedReadonlyScoped
?), with the currentScoped
class extending it.The text was updated successfully, but these errors were encountered: