XPK cleanup: integ tests and code cleanup #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshaniN
reviewed
Apr 17, 2024
| @@ -21,14 +21,14 @@ on: | |||
|
|
|||
| env: | |||
| # Names must be unique in parallel running tests. | |||
| TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools | |||
| TPU_CLUSTER_NAME: build-xpk-2-v4-8-nodepools-${{ github.run_id }}-${{ github.run_attempt }} | |||
There was a problem hiding this comment.
run_attempt may uniquely identify the cluster name, do you still think run_id is needed? https://stackoverflow.com/questions/54310050/how-to-version-build-artifacts-using-github-actions
| runs-on: [ubuntu-20.04] | ||
| concurrency: # We support one build or nightly test to run at a time currently. |
There was a problem hiding this comment.
Curious to know how "one of build or nightly" is ensured. I think the concurrency of jobs is once per group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
system: SystemCharacteristicsto arg types and return valuesadd_env_confignow returns int instead of using exceptions maintaining consistent flow with other functions in xpkTesting:
Integ tests