A misguided attempt to help #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand any of this. I'm completely lost at the part after you use the Regexes to detect numbers & strings. Maybe this works?
I mean, it says include the header in all files in BIG BOLD letters on the README
flagxor
reviewed
Sep 21, 2018
| @@ -1906,7 +1906,8 @@ | |||
| Skip('goto'); | |||
| var name = tok; | |||
| Next(); | |||
| // TODO: Implement. | |||
| curop += 'ip = labels["' + name + '"];\n'; | |||
There was a problem hiding this comment.
So this is down where it parses ON x GOTO a,b,c,d
What you had there would work for GOTO.
What's needed is actually parse a bunch of labels into a list and generated a lookup based on the int value.
I've filed an issue to track:
#25
There was a problem hiding this comment.
Ok well I'll try to stick to what I know when it comes to pull requests then 🤷♂️ Maybe I'll try to throw together some docs next...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand any of this. I'm completely lost after the part you use the Regexes to detect numbers & strings. Maybe this works?