Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Compare function #163

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: add Compare function #163

merged 2 commits into from
Jul 1, 2024

Conversation

it512
Copy link
Contributor

@it512 it512 commented Jun 30, 2024

@it512 it512 requested a review from a team as a code owner June 30, 2024 14:57
Copy link
Collaborator

@bormanp bormanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all it is fine. Just fix up the comment to match the other packages.

util.go Outdated
@@ -41,3 +42,8 @@ func xtob(x1, x2 byte) (byte, bool) {
b2 := xvalues[x2]
return (b1 << 4) | b2, b1 != 255 && b2 != 255
}

// Compare compare two uuids
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Compare returns an integer comparing two uuids lexicographically. The result will be 0 if a == b, -1 if a < b, and +1 if a > b.

Copy link
Contributor Author

@it512 it512 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok !
thank you!

@bormanp bormanp merged commit e8d82d3 into google:master Jul 1, 2024
6 checks passed
@it512 it512 deleted the cmp branch July 2, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants