Detect Bazel JUnit 5 test runner stack frames #1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the [community-maintained JUnit 5 test runner](https://github.com/bazel-contrib/rules_jvm#java_junit5_test) to the list of test framework packages to collapse or strip from stack traces.
|
@shs96c as the maintainer of rules_jvm. |
shs96c
reviewed
Mar 14, 2023
| @@ -354,6 +354,7 @@ private enum StackFrameType { | |||
| "junit", | |||
| "org.junit", | |||
| "androidx.test.internal.runner", | |||
| "com.github.bazel_contrib.contrib_rules_jvm.junit5", | |||
There was a problem hiding this comment.
That's the right package name for our runner.
cpovirk
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the community-maintained Bazel JUnit 5 test runner to the list of test framework packages to collapse or strip from stack traces.