Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Subject.equals and hashCode final? #247

Closed
cpovirk opened this issue Jun 20, 2016 · 1 comment
Closed

Make Subject.equals and hashCode final? #247

cpovirk opened this issue Jun 20, 2016 · 1 comment
Assignees
@kluever
Milestone
Release 1.0

Comments

@cpovirk
Copy link
Member

cpovirk commented Jun 20, 2016

I see two custom subjects that override them inside Google. I doubt that there's any good reason for this.
@kluever kluever self-assigned this Jun 20, 2016
@kluever
Copy link
Member

kluever commented Jun 22, 2016

Fixed

@kluever kluever closed this as completed Jun 22, 2016
cpovirk pushed a commit that referenced this issue Jun 22, 2016
@kluever @cpovirk
Make equals() and hashCode() final on Subject.
d6917b8 
Fixes #247
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=125528464
@cgruber cgruber modified the milestone: Release 1.0 Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kluever kluever

Labels
None yet
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
3 participants
@cgruber @cpovirk @kluever