Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login/logout events #1371

Merged
merged 19 commits into from
Jul 2, 2024
Merged

Login/logout events #1371

merged 19 commits into from
Jul 2, 2024

Conversation

mlw
Copy link
Member

@mlw mlw commented Jun 20, 2024 •
edited
Loading

This PR sets is the first step in adding support for the following event types:

ES_EVENT_TYPE_NOTIFY_LW_SESSION_LOGIN
ES_EVENT_TYPE_NOTIFY_LW_SESSION_LOGOUT
ES_EVENT_TYPE_NOTIFY_LW_SESSION_LOCK
ES_EVENT_TYPE_NOTIFY_LW_SESSION_UNLOCK
ES_EVENT_TYPE_NOTIFY_SCREENSHARING_ATTACH
ES_EVENT_TYPE_NOTIFY_SCREENSHARING_DETACH
ES_EVENT_TYPE_NOTIFY_OPENSSH_LOGIN
ES_EVENT_TYPE_NOTIFY_OPENSSH_LOGOUT
ES_EVENT_TYPE_NOTIFY_LOGIN_LOGIN
ES_EVENT_TYPE_NOTIFY_LOGIN_LOGOUT

The string and protobuf serializer implementations have been relegated into a separate branch for a future PR to try and keep this already large PR a bit smaller. So while this branch will subscribe to the new events, nothing is actually logged yet.

@mlw mlw added enhancement logging santad Work related to the Santa Daemon labels Jun 20, 2024
@mlw mlw mentioned this pull request Jun 20, 2024
Closed
russellhancox
russellhancox previously approved these changes Jun 21, 2024
View reviewed changes
Source/common/santa.proto Outdated Show resolved Hide resolved
Source/santad/Logs/EndpointSecurity/Serializers/BasicString.mm Outdated Show resolved Hide resolved
tburgin
tburgin previously approved these changes Jun 21, 2024
View reviewed changes
Source/santad/Logs/EndpointSecurity/Serializers/BasicString.mm Outdated Show resolved Hide resolved
@mlw mlw dismissed stale reviews from tburgin and russellhancox via 0abe70b June 22, 2024 20:32
@mlw mlw marked this pull request as ready for review July 2, 2024 13:53
@mlw mlw requested a review from a team as a code owner July 2, 2024 13:53
@mlw mlw requested a review from pmarkowsky July 2, 2024 13:53
@mlw mlw requested review from russellhancox and tburgin July 2, 2024 13:53
russellhancox
russellhancox requested changes Jul 2, 2024
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
Source/santad/EventProviders/EndpointSecurity/EnrichedTypes.h Outdated Show resolved Hide resolved
@mlw mlw requested a review from russellhancox July 2, 2024 20:22
@mlw mlw merged commit 08ce693 into google:main Jul 2, 2024
9 of 10 checks passed
@mlw mlw mentioned this pull request Jul 2, 2024
Merged
@mlw mlw added this to the 2024.7 milestone Jul 2, 2024
@mlw mlw mentioned this pull request Jul 3, 2024
Merged
@mlw mlw modified the milestones: 2024.7, 2024.6 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellhancox russellhancox russellhancox approved these changes

@pmarkowsky pmarkowsky Awaiting requested review from pmarkowsky

@tburgin tburgin Awaiting requested review from tburgin

Assignees
No one assigned
Labels
enhancement logging santad Work related to the Santa Daemon
Projects
None yet
Milestone
2024.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mlw @russellhancox @pmarkowsky @tburgin