Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue preventing rule import / export from working #1199

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Fix issue preventing rule import / export from working #1199

merged 5 commits into from
Oct 25, 2023

Conversation

pmarkowsky
Copy link
Contributor

This fixes an issue with the order of argument checking. That's blocking the use of the --import / --export.

It also adds a check to make sure that import and export only run by themselves.

@pmarkowsky pmarkowsky requested a review from a team as a code owner October 12, 2023 15:11
@pmarkowsky pmarkowsky added this to the 2023.9 Release milestone Oct 12, 2023
kallsyms
kallsyms reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@kallsyms kallsyms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the help string above removing the --json help (L67) and noting --import and --export take a path arg?

@pmarkowsky pmarkowsky merged commit 8c466b4 into google:main Oct 25, 2023
9 checks passed
@pmarkowsky pmarkowsky deleted the fix-santactl-rules branch October 25, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallsyms kallsyms kallsyms approved these changes

Assignees
No one assigned
Labels
santactl
Projects
None yet
Milestone
2023.9 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@pmarkowsky @kallsyms