Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option module include directory does not work with CMake #132

Closed
DanAlbert opened this issue Mar 16, 2021 · 1 comment · Fixed by #133
Closed

option module include directory does not work with CMake #132

DanAlbert opened this issue Mar 16, 2021 · 1 comment · Fixed by #133
Assignees
@DanAlbert
Labels
enhancement New feature or request

Comments

@DanAlbert
Copy link
Member

DanAlbert commented Mar 16, 2021 •
edited
Loading

Mirroring https://issuetracker.google.com/178594838 for tracking. There's no real reason for the module include directory to be required The module level include directory is optional, and CMake is unhappy if a non-existent directory is set for INTERFACE_INCLUDE_DIRECTORIES.
@DanAlbert DanAlbert added the enhancement New feature or request label Mar 16, 2021
@DanAlbert DanAlbert self-assigned this Mar 16, 2021
@DanAlbert DanAlbert changed the title [FR] include directory should be optional option module include directory does not work with CMake Mar 16, 2021
@DanAlbert DanAlbert added bug Something isn't working and removed enhancement New feature or request labels Mar 16, 2021
DanAlbert added a commit to DanAlbert/prefab that referenced this issue Mar 16, 2021
@DanAlbert
Omit empty include directories for CMake plugin.
fa4fdd7 
CMake emits an error for an INTERFACE_INCLUDE_DIRECTORIES value that
does not exist. To support build systems that do not preserve empty
include directories (like AGP), and to allow packages which do not
create the empty directory, omit that property when not needed.

Fixes google#132.
DanAlbert added a commit to DanAlbert/prefab that referenced this issue Mar 16, 2021
@DanAlbert
Omit empty include directories for CMake plugin.
1efd6e5 
CMake emits an error for an `INTERFACE_INCLUDE_DIRECTORIES` value that
does not exist. Our docs claim that this directory is optional, so
omit that property when not needed.

Fixes google#132.
@DanAlbert DanAlbert mentioned this issue Mar 16, 2021
Merged
DanAlbert added a commit that referenced this issue Mar 16, 2021
@DanAlbert
Omit empty include directories for CMake plugin.
6efeb7c 
CMake emits an error for an `INTERFACE_INCLUDE_DIRECTORIES` value that
does not exist. Our docs claim that this directory is optional, so
omit that property when not needed.

Fixes #132.
@DanAlbert
Copy link
Member Author

https://github.com/google/prefab/releases/tag/v1.1.3

(android.prefabVersion=1.1.3 in your gradle.properties file)

msatranjr pushed a commit to msft-mirror-aosp/platform.prebuilts.tools that referenced this issue Feb 8, 2023
@DanAlbert
Update default prefab version to 1.1.3.
2c54fcc 
Test: presubmit
Bug: google/prefab#128
Bug: google/prefab#132
Change-Id: I00ef7bf7a03b9ec5cfeadad06480310303de3934
@DanAlbert DanAlbert added enhancement New feature or request and removed bug Something isn't working labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit empty include directories for CMake plugin. DanAlbert/prefab
1 participant
@DanAlbert