Missing dependencies #128
Merged
Missing dependencies #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library projects are ambiguous when attempting to resolve their dependencies. Internally there are many variants and Gradle will throw a AmbiguousVariantSelectionException when it encounters this scenario. The result is that a null set of artifacts is returned from getResolvedArtifacts(). This change iterates through the dependency hierarchy's top levels manually to avoid attempting to automatically traverse a library project. Instead it will manually traverse the tree of library projects and only automatically traverse non-library dependencies.
jkasnicki
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
When attempting to call getResolvedArtifacts() on a top level ResolvedConfiguration for an application project that also has library projects an AmbiguousVariantSelectionException will throw. Gradle cannot determine which variant of the library project it should evaluate for artifacts. None of the library project variants lead to artifacts supported by this tool.
This change avoids that by stepping over the library project itself and recursively walking the library project's dependencies. If the library project depends on other library projects, they are avoided in the same way. Once a direct, non-library-project dependency is reached, getAllModuleArtifacts() returns the self-inclusive artifact tree stemming from it.
The result is the set of transitive external dependencies of the application and its library projects.
This also includes separate commits to bump the version and ignore the generated repo folder, fix a logging gap, and enable the use of automatic formatting.