HCL: move build script upstream #7907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about moving the build script upstream to give you more flexibility to make modifications? See for example how Tesseract does this: https://github.com/google/oss-fuzz/blob/master/projects/tesseract-ocr/build.sh. |
The HCL build script is now maintained upstream. Base image is also updated to correct base image for Go 1.18 fuzz testing.
kmoe
force-pushed
the
hcl-go-native-fuzzing
branch
from
ce5821a
to
eadf25e
Compare
|
Thanks, @AdamKorcz: I've updated accordingly. Work on enabling Go 1.18 fuzz testing can now happen upstream. |
|
Looks good. Let's merge after hashicorp/hcl#554 has landed. |
|
Can you get upstream to merge so we can move on with this? |
|
hashicorp/hcl#554 is merged at last. |
|
Ping me if the tests succeed here please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HCL build script is now maintained upstream. Docker base image is also updated to correct base image for Go 1.18 fuzz testing.