Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin deepdiff #482

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Unpin deepdiff #482

merged 2 commits into from
Jun 20, 2024

Conversation

richard-to
Copy link
Collaborator

Does not look like there any breaking changes: https://zepworks.com/deepdiff/current/changelog.html

Ref #468

Does not look like there any breaking changes: https://zepworks.com/deepdiff/current/changelog.html
Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run:

$ bazel run //build_defs:pip_requirements.update

I forget this too :(

Otherwise, it's just not actually changing the dependency version used (which is from requirements_lock.txt)

https://google.github.io/mesop/internal/development/#third-party-packages-pip

@richard-to
Copy link
Collaborator Author

richard-to commented Jun 20, 2024

You need to run:

$ bazel run //build_defs:pip_requirements.update

I forget this too :(

Otherwise, it's just not actually changing the dependency version used (which is from requirements_lock.txt)

https://google.github.io/mesop/internal/development/#third-party-packages-pip

Good call there. The interesting thing is that I had run the command. So I ran it again. The locked requirements didn't update for some reason. I had to manually remove the entry from the lock file.

Turns out version 7 does break something. I do remember now that the diff output is a bit different. I remember it being more verbose. Though it's possible if we need to we could reconcile the formats if absolutely necessary.

But for now I just pinned to any version of 6 where 6.7.1 is the last version of 6.

@wwwillchen
Copy link
Collaborator

You need to run:
$ bazel run //build_defs:pip_requirements.update
I forget this too :(
Otherwise, it's just not actually changing the dependency version used (which is from requirements_lock.txt)
https://google.github.io/mesop/internal/development/#third-party-packages-pip

Good call there. The interesting thing is that I had run the command. So I ran it again. The locked requirements didn't update for some reason. I had to manually remove the entry from the lock file.

Turns out version 7 does break something. I do remember now that the diff output is a bit different. I remember it being more verbose. Though it's possible if we need to we could reconcile the formats if absolutely necessary.

But for now I just pinned to any version of 6 where 6.7.1 is the last version of 6.

yeah, i've noticed that too. I'm unclear whether that's WAI or a bug.

@richard-to richard-to merged commit 13070ee into google:main Jun 20, 2024
3 checks passed
wwwillchen pushed a commit to wwwillchen/mesop that referenced this pull request Jun 25, 2024
* Unpin deepdiff

Pin to version 6 of deep diff since State diffing breaks using version 7. This may be because the diff format is a bit different, but didn't verify.
@richard-to richard-to deleted the unpin-deepdiff branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants