Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Mixtral test into two scripts #616

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Split Mixtral test into two scripts #616

merged 1 commit into from
Apr 25, 2024

Conversation

RissyRan
Copy link
Collaborator

Description

Split Mixtral end-to-end test into 2 scripts, and this PR works with XL ML PR.

Tests

Please describe the tests that you ran on Cloud VM to verify changes.

Instruction and/or command lines to reproduce your tests: ...
Build image, and upload to Airflow and test.

List links for your tests (use go/shortn-gen for any internal link): ...
Airflow test: link
XPK test: link

@RissyRan RissyRan mentioned this pull request Apr 23, 2024
Merged
4 tasks
gobbleturk
gobbleturk approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made some suggestions for changing the comments here, feel free to take what you think is helpful for future code readers. I think there is one incomplete sentence with "both" which should be fixed

end_to_end/tpu/mixtral/8x7b/2_test_mixtral.sh Outdated Show resolved Hide resolved
end_to_end/tpu/mixtral/8x7b/2_test_mixtral.sh Outdated Show resolved Hide resolved
end_to_end/tpu/mixtral/8x7b/2_test_mixtral.sh Outdated Show resolved Hide resolved
end_to_end/tpu/mixtral/8x7b/1_test_mixtral.sh Outdated Show resolved Hide resolved
@RissyRan RissyRan force-pushed the separate_mixtral branch 2 times, most recently from d6104c7 to f0c3610 Compare April 23, 2024 23:07
rwitten
rwitten approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@rwitten rwitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have Anisha provide approval here.

@rwitten rwitten requested a review from A9isha April 24, 2024 03:01
@A9isha A9isha self-requested a review April 25, 2024 17:10
A9isha
A9isha approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@A9isha A9isha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ran

@copybara-service copybara-service bot merged commit f6060b0 into google:main Apr 25, 2024
4 of 5 checks passed
@RissyRan RissyRan mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwitten rwitten rwitten approved these changes

@gobbleturk gobbleturk gobbleturk approved these changes

@A9isha A9isha A9isha approved these changes

Assignees

@rwitten rwitten

@gobbleturk gobbleturk

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RissyRan @rwitten @gobbleturk @A9isha