add unit test for checkpoint compatibility between tfds and grain #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aireenmei
force-pushed
the
aireen/grain_unit_test2
branch
from
3c3e298
to
7f2e7f1
Compare
rwitten
approved these changes
Mar 5, 2024
| @@ -114,6 +114,10 @@ jobs: | |||
| run: | | |||
| docker run -v /home/runner/actions-runner/_work/maxtext/maxtext:/app --rm --privileged maxtext_base_image bash -c \ | |||
| 'bash end_to_end/test_checkpointing.sh runner gs:https://runner-maxtext-logs gs:https://maxtext-dataset False c4-array_record' | |||
| - name: Test checkpoint compatibility | |||
| run: | | |||
| docker run -v /home/runner/actions-runner/_work/maxtext/maxtext:/app --rm --privileged maxtext_base_image bash -c \ | |||
There was a problem hiding this comment.
My preference would be for this to be in XLML not GH runner because I believe it is slow relative to the coverage. Feel free to let me know if you disagree.
There was a problem hiding this comment.
Right now this test runs ~ 1m45s, which is comparable with some other GH unit tests. Given that we are working on some checkpointing change, I would like to add it to GH now. I'll move it to XLML later. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test to make sure checkpoints generated by tfds pipeline and grain pipeline are compatible.