Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xpk] Use kueue github repo manifest file instead of local one #201

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Obliviour
Copy link
Collaborator

TESTED=yes, ran xpk cluster create, and ran simple workloads that waited in the kueue.

Copy link
Collaborator

@rwitten rwitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the diff between these files? I do think there is a diff...

@rwitten rwitten removed their assignment Oct 11, 2023
@Obliviour
Copy link
Collaborator Author

Obliviour commented Oct 11, 2023

Have you checked the diff between these files? I do think there is a diff...

Here is the diff.

diff kueue_manifests.yml kueue_manifests_to_upgrade_to.yml
9859,9861c9859,9860
<     waitForPodsReady:
<       enable: true
<       timeout: 20m
---
>     #waitForPodsReady:
>     #  enable: true
9877,9894d9875
< data:
<   controller_manager_config.yaml: |
<     apiVersion: config.kueue.x-k8s.io/v1beta1
<     kind: Configuration
<     namespace: kueue-system
<     health:
<       healthProbeBindAddress: :8081
<     metrics:
<       bindAddress: :8080
<     webhook:
<       port: 9443
<     waitForPodsReady:
<       enable: true
<       timeout: 20m
<     integrations:
<       frameworks:
<       - "batch/job"
<       - "jobset.x-k8s.io/jobset"

TESTED=yes, ran xpk cluster create, and ran simple workloads that waited in the kueue.
@Obliviour Obliviour merged commit c66bf1f into main Oct 11, 2023
7 checks passed
@Obliviour Obliviour deleted the kueue_manifest branch October 13, 2023 21:43
A9isha pushed a commit that referenced this pull request Apr 11, 2024
* copy test scripts from release tag

* use checkout -b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants