Add set -e to scripts

google · Sep 11, 2023 · af9e480 · af9e480
1 parent 6ce556e
commit af9e480
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 0 deletions.
diff --git a/MaxText/configs/largest_job/128b.sh b/MaxText/configs/largest_job/128b.sh
@@ -2,6 +2,9 @@ echo "Running 128b.sh"
 # Example command to invoke this script
 # bash MaxText/configs/largest_job/128b.sh
 
+# Stop execution if any command exits with error
+set -e
+
 export OUTPUT_PATH="gs:https://maxtext-experiments-multipod"
 export DATASET_PATH="gs:https://maxtext-dataset/"
 

diff --git a/MaxText/configs/largest_job/32b.sh b/MaxText/configs/largest_job/32b.sh
@@ -2,6 +2,9 @@ echo "Running 32b.sh"
 # Example command to invoke this script
 # bash MaxText/configs/largest_job/32b.sh
 
+# Stop execution if any command exits with error
+set -e
+
 export OUTPUT_PATH="gs:https://maxtext-experiments-multipod"
 export DATASET_PATH="gs:https://maxtext-dataset/"
 

diff --git a/MaxText/configs/largest_job/64b_big_batch.sh b/MaxText/configs/largest_job/64b_big_batch.sh
@@ -2,6 +2,9 @@ echo "Running 64b_big_batch.sh"
 # Example command to invoke this script
 # bash MaxText/configs/largest_job/64b_big_batch.sh 
 
+# Stop execution if any command exits with error
+set -e
+
 export OUTPUT_PATH="gs:https://maxtext-experiments-multipod"
 export DATASET_PATH="gs:https://maxtext-dataset/"
 

diff --git a/MaxText/configs/largest_job/64b_small_batch.sh b/MaxText/configs/largest_job/64b_small_batch.sh
@@ -2,6 +2,9 @@ echo "Running 64b_small_batch.sh"
 # Example command to invoke this script
 # bash MaxText/configs/largest_job/64b_small_batch.sh
 
+# Stop execution if any command exits with error
+set -e
+
 export OUTPUT_PATH="gs:https://maxtext-experiments-multipod"
 export DATASET_PATH="gs:https://maxtext-dataset/"
 

diff --git a/gke_rto_setup.sh b/gke_rto_setup.sh
@@ -1,5 +1,8 @@
 echo "Running gke_rto_setup.sh..."
 
+# Stop execution if any command exits with error
+set -e
+
 echo "Adjust RTO and apply non cache copy"
 first_line_res=$(ip route show | head -n 1)
 if [[ "$(echo "$first_line_res" | grep "rto_min lock 5ms" | wc -l)" -eq 0 ]]; then

diff --git a/rto_setup.sh b/rto_setup.sh
@@ -1,4 +1,8 @@
 echo "Running rto_setup.sh..."
+
+# Stop execution if any command exits with error
+set -e
+
 first_line_res=$(ip route show | head -n 1)
 sudo ip route change ${first_line_res} rto_min 5ms
 sudo ethtool -K ens9 tx-nocache-copy on