Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the modifiers to private from public and lift return out of 'if' #1088

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

heli-os
Copy link
Contributor

@heli-os heli-os commented Aug 31, 2022

Hi i am Heli who using ksp.

First, changed some codes to not use the platform type. platform type requires unnecessary boilerplate(!!, let trick, ...) And open source is a guide to writing code.

so i think bad code examples should be deleted.

Second, Lift return out of 'if'

Third, change the modifiers to private from public

thanks. 🙇

--
There is no change that users can feel.

@google-cla
Copy link

google-cla bot commented Aug 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@heli-os
Copy link
Contributor Author

heli-os commented Sep 2, 2022

Can anyone please review it?

@neetopia
Copy link
Collaborator

neetopia commented Sep 8, 2022

I think the change for combining return statement and private val make sense to me, but I don't get the benefit of adding explicit types to the rest of your change, if no specific reasons, maybe let's not touch them.

@heli-os
Copy link
Contributor Author

heli-os commented Sep 9, 2022

@neetopia
okay, It would be better not to touch it.

I removed the added explicit type.

@heli-os heli-os changed the title fix: change some codes to not use platform type change the modifiers to private from public and lift return out of 'if' Sep 9, 2022
@neetopia neetopia merged commit b1d1f6c into google:main Sep 9, 2022
@neetopia
Copy link
Collaborator

neetopia commented Sep 9, 2022

Thanks for your PR!

github-actions bot pushed a commit that referenced this pull request Sep 9, 2022
@heli-os heli-os deleted the fix/platform_type branch September 10, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants