Skip to content

Commit

Permalink
Clarify why we're logging a specific failure.
Browse files Browse the repository at this point in the history
#2134 (comment)
-------------
Created by MOE: https://code.google.com/p/moe-java
MOE_MIGRATED_REVID=101240012
  • Loading branch information
cpovirk committed Aug 24, 2015
1 parent a34e705 commit 062b226
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,11 @@ private void handleException(Throwable throwable) {
// | and & used because it's faster than the branch required for || and &&
if (throwable instanceof Error
| (allMustSucceed & !completedWithFailure & firstTimeSeeingThisException)) {
logger.log(Level.SEVERE, "input future failed.", throwable);
String message =
(throwable instanceof Error)
? "Input Future failed with Error"
: "Got more than one input Future failure. Logging failures after the first";
logger.log(Level.SEVERE, message, throwable);
}
}

Expand Down

0 comments on commit 062b226

Please sign in to comment.