Fix typeArguments array not being cloned when resolving ParameterizedType with changed owner #2706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an inconsistency in
$Gson$Types#resolve()
where theParameterizedType#getActualTypeArguments()
array is only cloned when the resolved owner-type has not changed from the original owner-type.Description
In most cases this is a non-issue, as usually all
ParameterizedType
implementations clone the array themselves when invoking thegetActualTypeArguments()
getter. However, this is not guaranteed.Cloning the array only when the owner-type didn't change seems like an inconsistency and an oversight, so this PR is trying to fix that.
Checklist
This is automatically checked by
mvn verify
, but can also be checked on its own usingmvn spotless:check
.Style violations can be fixed using
mvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes.null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors