Referrer API must return correct Content-Type #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the spec, Content-Type header MUST be set to application/vnd.oci.image.index.v1+json This is important as GAR today (OCI 1.0) redirect "referrers" API call to the authentication page, and doing so the call return 200 OK + content-type: text/html.
imjasonh
approved these changes
Jul 2, 2024
jonjohnsonjr
approved these changes
Jul 2, 2024
renovate bot
added a commit
to validator-labs/validator-plugin-oci
that referenced
this pull request
Jul 9, 2024
…0.20.0 (#207) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry) | `v0.19.2` -> `v0.20.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/go-containerregistry (github.com/google/go-containerregistry)</summary> ### [`v0.20.0`](https://togithub.com/google/go-containerregistry/releases/tag/v0.20.0) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.19.2...v0.20.0) #### What's Changed - Referrer API must return correct Content-Type by [@​GregoireW](https://togithub.com/GregoireW) in [google/go-containerregistry#1968 - 🚨 POTENTIALLY BREAKING: Restore blind-write to remote.Put by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [google/go-containerregistry#1970 #### New Contributors - [@​GregoireW](https://togithub.com/GregoireW) made their first contribution in [google/go-containerregistry#1968 **Full Changelog**: google/go-containerregistry@v0.19.2...v0.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-oci). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnbyJdfQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec, https://github.com/opencontainers/distribution-spec/blob/main/spec.md#listing-referrers Content-Type header MUST be set to application/vnd.oci.image.index.v1+json.
This is important as GAR today (OCI 1.0) redirect "referrers" API call to the google console authentication page, and doing so the call return 200 OK + content-type: text/html.
As the test use the registry package it is quite difficult to set a test explicitly on this part.