Add the logtostdout and colorlogtostdout flag to allow logging to stdout #790
Conversation
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
==========================================
+ Coverage 72.78% 72.93% +0.15%
==========================================
Files 17 17
Lines 3259 3281 +22
==========================================
+ Hits 2372 2393 +21
- Misses 887 888 +1
Continue to review full report at Codecov.
|
|
@sergiud I have add a new file( |
|
The tests of MSVC builds are failing. Could you please rebase onto current master and see if this helps? |
git-hulk
force-pushed
the
feature/logs-to-stdout
branch
from
664e178
to
0df1696
Compare
sergiud
force-pushed
the
feature/logs-to-stdout
branch
from
0df1696
to
2f0c27a
Compare
|
I fixed the formatting and revised the commit message. Some tests seem to be flaky though which is likely not your fault. |
sergiud
force-pushed
the
feature/logs-to-stdout
branch
from
2f0c27a
to
2f9a5dd
Compare
|
@sergiud cool, thanks for your great help! |
|
@sergiud How do you think about this PR? Does this implementation make sense for you? |
|
I already skipped through the PR and it does make sense to me. However, I would like to wait for additional comments from users (if any). So please hold tight. |
|
ok, cool. Sorry for pushing you. |
|
Thanks for your suggestions, has resolved those issues. |
|
Looks great! |
Currently, glog allows to use of logtostderr to send error logs to stderr, but many log tailers would regard logs from stderr as error logs. So we want to send non-error logs to stdout and only send error logs to stderr according to the stderrthreshold.
sergiud
force-pushed
the
feature/logs-to-stdout
branch
from
a5f29ef
to
180b700
Compare
Currently, glog allowed to use logtostderr to send error logs to stderr,
but many log tailors would regard logs from stderr as error logs. So we
want to send non-error logs to stdout and only send error logs to stderr
according to the stderrthreshold.
Resolved #701