Use static to define CheckStackTrace on non-GNU
#429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It worked. I'm not 100% sure, but I think the compiler returns the address of PLT-like thing for non-static function on Windows. |
|
Pinging @andschwa . I guess you may know a better solution :) |
shinh
changed the title
static to define CheckStackTrace on non-GNUstatic to define CheckStackTrace on non-GNU
|
@shinh This looks good to me 🎉 (I'm no Windows expert, I just got an impl working based on docs 😆) |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
for `&CheckStackAddress`, VisualStudio emits address of a trampoline like PLT, not the actual address of `CheckStackTrace`. We need address of `CheckStackTrace` to guess the address range of the function. `static` function seems to return the actual address of the function. Fixes google#421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #421. I don't know if this work.