Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gflags to latest master #277

Merged
merged 1 commit into from
Jan 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update gflags to latest master
This means that gflags no longer leaks config.h, so I had to fix a bug
in glog.bzl where config.h is generated at the wrong path.

I also switched to the best-practice for depending on git repositories,
ie using http_archive with a mirror.
  • Loading branch information
drigz committed Dec 19, 2017
commit 2a593235ba0967ae375752ffac2d4e98b440a1df
10 changes: 7 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
git_repository(
http_archive(
name = "com_github_gflags_gflags",
remote = "https://github.com/gflags/gflags.git",
tag = 'v2.2.1',
sha256 = "6e16c8bc91b1310a44f3965e616383dbda48f83e8c1eaa2370a215057b00cabe",
strip_prefix = "gflags-77592648e3f3be87d6c7123eb81cbad75f9aef5a",
urls = [
"https://mirror.bazel.build/github.com/gflags/gflags/archive/77592648e3f3be87d6c7123eb81cbad75f9aef5a.tar.gz",
"https://github.com/gflags/gflags/archive/77592648e3f3be87d6c7123eb81cbad75f9aef5a.tar.gz",
],
)
2 changes: 1 addition & 1 deletion bazel/glog.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ EOF
'src/config.h.cmake.in',
],
outs = [
'glog_internal/src/config.h',
'glog_internal/config.h',
],
cmd = "awk '{ gsub(/^#cmakedefine/, \"//cmakedefine\"); print; }' $< > $@",
)
Expand Down