Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHECK_XX variants do not compile if nullptr is an argument #341

Closed
bretmckee opened this issue Jul 6, 2018 · 0 comments · Fixed by #641 or #646
Closed

CHECK_XX variants do not compile if nullptr is an argument #341

bretmckee opened this issue Jul 6, 2018 · 0 comments · Fixed by #641 or #646
Assignees
@sergiud
Labels
enhancement
Milestone
0.5

Comments

@bretmckee
Copy link

This prevents things like:

CHECK_NE(ptr, nullptr);

from compiling
bretmckee added a commit to bretmckee/glog that referenced this issue Jul 6, 2018
@bretmckee
Adds CHECK support for nullptr. (fixes google#341)
133b38a 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
bretmckee added a commit to bretmckee/glog that referenced this issue May 24, 2019
@bretmckee
Adds CHECK support for nullptr. (fixes google#341)
f2cf2e1 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
@sergiud sergiud closed this as completed Mar 30, 2021
sergiud pushed a commit to sergiud/glog that referenced this issue Apr 8, 2021
@bretmckee @sergiud
CHECK support for nullptr (fixes google#341)
be3f421 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
@sergiud sergiud reopened this Apr 8, 2021
@sergiud sergiud self-assigned this Apr 8, 2021
@sergiud sergiud added this to the 0.5 milestone Apr 8, 2021
@sergiud sergiud mentioned this issue Apr 8, 2021
Merged
@sergiud sergiud linked a pull request Apr 8, 2021 that will close this issue
CHECK support for nullptr (fixes #341) #641
Merged
sergiud pushed a commit to sergiud/glog that referenced this issue Apr 8, 2021
@sergiud
CHECK support for nullptr (fixes google#341)
2e5460b 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
sergiud pushed a commit to sergiud/glog that referenced this issue Apr 8, 2021
@sergiud
CHECK support for nullptr (fixes google#341)
9bce407 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
sergiud pushed a commit to sergiud/glog that referenced this issue Apr 8, 2021
@sergiud
CHECK support for nullptr (fixes google#341)
06e72c7 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
sergiud pushed a commit to sergiud/glog that referenced this issue Apr 9, 2021
@sergiud
CHECK support for nullptr (fixes google#341)
c7656c3 
This allows CHECK_NE(foo, nullptr) to compile and produces "nullptr" for the
string representation of nullptr.
sergiud added a commit that referenced this issue Apr 12, 2021
@sergiud
Merge pull request #641 from sergiud/nullptr
0efaa59 
CHECK support for nullptr (fixes #341)
@sergiud sergiud mentioned this issue May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiud sergiud

Labels
enhancement
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

CHECK support for nullptr (fixes #341) sergiud/glog
release 0.5 sergiud/glog
2 participants
@bretmckee @sergiud