[Bazel] config.h: No such file or directory

[calder]

When building a Bazel project that imports glog, I get the following error:

ERROR: .../external/com_google_glog/BUILD:5:1: C++ compilation of rule '@com_google_glog//:glog' failed (Exit 1)
In file included from external/com_google_glog/src/utilities.h:75:0,
                 from external/com_google_glog/src/demangle.cc:38:
external/com_google_glog/src/base/mutex.h:105:64: fatal error: config.h: No such file or directory
compilation terminated.

This could be a regression in e6e2e13 bazel/glog.bzl:

-            '/'.join([PACKAGE_NAME, 'config.h']) if PACKAGE_NAME else 'config.h',
+            'glog_internal/src/config.h',

Replacing glog_internal/src/config.h with config.h fixes the issue.

[drigz]

This should be fixed by #277, could you try using the latest glog?

[drigz]

Closing - please reopen if you're still seeing this with the latest glog.

[jondo2010]

It looks like this is still a problem when building without gflags:

# Override the upstream BUILD file to disable gflags dependency
new_git_repository(
    name = "com_google_glog",
    remote = "https://github.com/google/glog.git",
    commit = "e0341da07bf7cdc00eafdc00744a807a7e5ba427", # Current head
    build_file_content = """
load(':bazel/glog.bzl', 'glog_library')
glog_library(with_gflags=False)
"""
)

INFO: Found 1 target...
ERROR: /home/john/.cache/bazel/_bazel_john/b74fab4f1d4785d9b546125b63063446/external/com_google_glog/BUILD.bazel:3:1: C++ compilation of rule '@com_google_glog//:glog' failed (Exit 1)
In file included from external/com_google_glog/src/utilities.h:75:0,
                 from external/com_google_glog/src/raw_logging.cc:34:
external/com_google_glog/src/base/mutex.h:105:64: fatal error: config.h: No such file or directory
compilation terminated.

[drigz]

@jondo2010 Thanks for the report! Looks like this was never tested, and sadly I can't see an easy way to test this automatically.

Let me know if #314 works for you.

Also, I could fix this in such a way that it would be tested in CI, but then you'd have to switch from using new_git_repository() to using git_repository() and depending on @com_google_glog//:glog_without_gflags. From a user standpoint, would you prefer that or would it just be a frustrating change?