Remove span ConstIterator/cbegin()/cend(). #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::span lacks these; make the flatbuffers STL emulation and tests match. This fixes a compile error in C++20 mode when using std::span. Bug: chromium:1284275
dbaileychess
approved these changes
May 10, 2022
sssooonnnggg
pushed a commit
to sssooonnnggg/flatbuffers
that referenced
this pull request
Aug 8, 2022
std::span lacks these; make the flatbuffers STL emulation and tests match. This fixes a compile error in C++20 mode when using std::span. Bug: chromium:1284275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::span lacks these; make the flatbuffers STL emulation and tests
match. This fixes a compile error in C++20 mode when using std::span.
Bug: chromium:1284275