[swift] add 'has<ArrayName>' property to check optional array presence in mes…

[mr-swifter]

Hello,

I came across issue #7270 and found it would be a very useful feature. It is a pull request to fix the issue.

Exist property added to generation of Swift code.

The change is tested manually in all variants: no vector (property returns false), empty vector (property returns true, count returns 0) and non-empty vector (property returns true, count returns number of items).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[mustiikhalil]

@mr-swifter Thanks for opening the PR.

• Can you rename it to be similar to how apple has their variables: has{{NAME_FIELD}}

• Can you add test cases where you cover the following cases, you will need to regenerate the code:
  - Add a vector with items in it, so the results will be hasIntVector = true, count = 1
  - Add a vector with no items in it, so the results will be hasIntVector = true, count = 0
  - Do not serialize a vector, and the results will be hasIntVector = false, count = 0

[mr-swifter]

@mustiikhalil , thanks for feedback, I renamed the property and added unit test.

[mustiikhalil]

@mr-swifter looks good, however you will need to:
1- Run the code generation to add this to all the generated codes. Check Scripts and add this file to it, and also add it to SwiftTests.sh
2- Sign the CLA

[mr-swifter]

@mustiikhalil , thanks for guiding me through that. points 1 and 2 are done, squashed to a single commit for convenience.

[mustiikhalil]

@mr-swifter sorry was a bit under the weather lately, looked at the PR looks good. But I think I kinda didn't explain myself in a better way earlier, we need to add the generated code to the python script too linked here. I think just adding it like what's mentioned below would be good

flatc(SWIFT_OPTS, schema="optional_scalars.fbs", prefix=swift_prefix)
flatc(SWIFT_OPTS, schema="vector_has_test.fbs", prefix=swift_prefix) // new

[mr-swifter]

Aha, got you now, let me add this.

[mr-swifter]

@mustiikhalil, done! generate_code.py changes a bit generated swift code, so I also committed this to make sure check_generate_code.py gives no diff.

[mustiikhalil]

@mr-swifter can you rebase master and force push again. it seems that the android CI is acting up

[mr-swifter]

Sure, I can do it, but as I can see CI / Build Android is failing on main branch as well, so seems rebase will not help. Or do I miss something?

[mustiikhalil]

Yeah its failing on master but if you see this #7293 pr, you would see that they are passing.

[mustiikhalil]

@mr-swifter Thanks!

[mr-swifter]

Thanks for help @mustiikhalil! Sorry didn't complete rebase, I was on holidays, but see you merged it, thanks!

[ghost]