Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle +/-inf in protos #7256

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Handle +/-inf in protos #7256

merged 2 commits into from
Apr 19, 2022

Conversation

dbaileychess
Copy link
Collaborator

Protos allow inf, +inf, and -inf for specifying float constants. The fbs parser was not handling this correctly.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Apr 19, 2022
@dbaileychess
Copy link
Collaborator Author

@vglavnyy

aardappel
aardappel reviewed Apr 19, 2022
View reviewed changes
src/idl_parser.cpp Outdated Show resolved Hide resolved
src/idl_parser.cpp Outdated Show resolved Hide resolved
tests/prototest/test.golden Show resolved Hide resolved
@dbaileychess dbaileychess merged commit ccfb4c2 into google:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aardappel aardappel aardappel approved these changes

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbaileychess @aardappel