[Swift] Fixes a bug for create function #7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bd18f7
to
22d2a72
Compare
|
@dbaileychess I'm not sure why the cpp linter is failing :/ since there wasn't even a change in the headers for the swift cpp generator |
22d2a72
to
f558ac4
Compare
|
Working on it now: #7229 I just enabled the check, but something is broke. |
f558ac4
to
3a217ec
Compare
|
CI seems stuck, going to wait until the queues are cleared. |
|
Good to go? |
|
Yep! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the create function doesnt optional + required items.
Closes #7215