Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 support #28

Closed
gitpushdashf opened this issue Dec 2, 2020 · 7 comments
Closed

Python 3.9 support #28

gitpushdashf opened this issue Dec 2, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@gitpushdashf
Copy link

Currently, google-fhir requires Python 3.7 or 3.8. With 3.9 out in production, what would it take to support it?

Thank you!

@Cam2337
Copy link
Collaborator

Cam2337 commented Dec 3, 2020

IIRC there may be some minor changes that need to happen with primitive time utils to support 3.9, but that's all that sticks out in my mind. I would like to land a couple minor improvements to the infra around testing pypi artifacts, but then would be happy to take a look at getting this in!

@Cam2337 Cam2337 self-assigned this Dec 3, 2020
@Cam2337 Cam2337 added the enhancement New feature or request label Dec 3, 2020
@gitpushdashf
Copy link
Author

That sounds good, thank you!

@gitpushdashf
Copy link
Author

Hey! Do you have any update on this by chance?

@Cam2337
Copy link
Collaborator

Cam2337 commented Apr 22, 2021

I went ahead and made the minor modifications to support Python 3.9, and added some additional support in build_distribution.sh to test against all supported major/minor versions prior to staging the release artifacts. These changes are now in review. Apologies for the delay!

@gitpushdashf
Copy link
Author

Fantastic! Thank you so much!

christianlent pushed a commit to anthem-ai/fhir-helpers that referenced this issue Apr 25, 2021
@Cam2337
Copy link
Collaborator

Cam2337 commented May 11, 2021

Replicating a queue of changes -- note that the support for this is in the repository, but will not be visible to pip/pypi users until we cut a new package. Am going to try and target tomorrow or the next day to do this.

@gitpushdashf
Copy link
Author

Awesome! We're very much looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants