-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python json -> protobuf "cannot be parsed as a reference" #24
Comments
Interesting, yes a code sample would be fantastic!
Just so I'm clear, you're saying an older Synthea works o.k.? What's the version that was working for you? Thanks for bringing it to our attention! |
Yeah, an older one works fine. Synthea wasn't tagging releases for over a year and the only (easy) option was downloading the .jar made from master. https://github.com/synthetichealth/synthea/releases Now it turns out that in September they made releases, but those releases seem to be build for openjdk12 and not openjdk8... synthetichealth/synthea#813 Anyway, here's a snippet of the new output.
Thanks for getting back to me. Let me come up with a code snippet. |
Ok, hopefully this helps. I made/activated a virtualenv, pip3 installed google-fhir and requests, then ran the script in an empty directory. Thanks! |
I'm having some weird behavior. If I use just the old Synthea JAR file, it seems to generate good output. If I switch to the latest one, it breaks. If I switch back, it's still broken, maybe for hours. It's like Synthea caches something that's throwing it off. |
e5545c13-98db-083f-f580-b22157aa82a8.json.txt Here's one generated that I'm having issues with. |
Ok, the old .jar actually does work fine -- I was screwing up. But the new jar does produce output that google-fhir can't handle. I need to find somewhere to host that file. |
Here's a Synthea version that is working. https://github.com/gitpushdashf/synthea/releases/tag/v2.5.9 |
Thanks for the details! I believe that these patterns started being introduced in Synthea with SHA: Since Will look into correcting this behavior so that we're taking appropriate action. |
Circling back on this -- the change was trivial but it required additional work to some things downstream. I have a fix internally now that's going through review. In the meantime as we discussed you should be able to avoid any problematic Synthea by sticking to versions earlier than
See more at: https://github.com/synthetichealth/synthea/blob/master/src/main/resources/synthea.properties#L18 Appreciate the patience and help in identifying this! :) |
See more at: google/fhir#24. PiperOrigin-RevId: 341899191
Thank you! That's good to know. |
The latest Synthea gives different output. An older version works fine for me, however the latest results in:
ValueError: String 'Practitioner?identifier=http:https://hl7.org/fhir/sid/us-npi|9999999959' cannot be parsed as a reference.
I can write up a code sample if need be.
This is using Synthea from master: https://github.com/synthetichealth/synthea/releases/download/master-branch-latest/synthea-with-dependencies.jar
It looks like they have some versions released more recently, I will try those.
The text was updated successfully, but these errors were encountered: