-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate types #16
Comments
I'll investigate whether those two files should exist simultaneously. Is this something you're seeing across multiple file pairs or just this pair? |
I believe it's not just this one, but this is the worst offender I've found. Thanks for taking a look! |
nickgeorge
pushed a commit
that referenced
this issue
Jul 31, 2020
…taType proto in #16. PiperOrigin-RevId: 324228096
Fixed that one. We didn't notice any others, so I'm going to close this issue for now, but please let us know if you notice see any we missed, and thanks for the report! |
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are duplicate types which seems iffy. Identical files with just different names.
For example:
https://github.com/google/fhir/blob/master/proto/r4/core/profiles/data_element_constraint_on_element_definition_data_type.proto#L31
https://github.com/google/fhir/blob/master/proto/r4/core/profiles/datatypes.proto#L31
Would there be any way to trim this down to just one file for a certain type definition?
This is one of the things keeping
buf check lint
from passing: #15More information here: bufbuild/buf#99
Thank you!
The text was updated successfully, but these errors were encountered: